Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check protocol version is supported #199

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Check protocol version is supported #199

merged 1 commit into from
Jan 11, 2024

Conversation

slinkydeveloper
Copy link
Contributor

Fix #198

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 10, 2024 •
edited
Loading

Test Results

102 files  ±0  102 suites  ±0   10m 32s ⏱️ - 4m 40s
 93 tests ±0   93 ✅ +1  0 💤 ±0  0 ❌  - 1 
232 runs  ±0  232 ✅ +1  0 💤 ±0  0 ❌  - 1 

Results for commit 4763d23. ± Comparison against base commit b715d5b.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 10, 2024 •
edited
Loading

Unit Test Results

  46 files  ±0    46 suites  ±0   3m 42s ⏱️ -53s
596 tests +1  589 ✔️ +1  7 💤 ±0  0 ❌ ±0 
597 runs  +1  590 ✔️ +1  7 💤 ±0  0 ❌ ±0 

Results for commit 4763d23. ± Comparison against base commit b715d5b.

♻️ This comment has been updated with latest results.

tillrohrmann
tillrohrmann approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating this PR @slinkydeveloper. LGTM. +1 for merging.

@slinkydeveloper slinkydeveloper merged commit ffaa961 into main Jan 11, 2024
5 checks passed
@slinkydeveloper slinkydeveloper deleted the issues/198 branch January 11, 2024 12:45
@slinkydeveloper slinkydeveloper mentioned this pull request Jan 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tillrohrmann tillrohrmann tillrohrmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check the Java SDK respects the protocol_version flag
2 participants
@slinkydeveloper @tillrohrmann